-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: fix ElasticQuota creation failure on startup #1845
scheduler: fix ElasticQuota creation failure on startup #1845
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1845 +/- ##
==========================================
- Coverage 67.03% 67.02% -0.01%
==========================================
Files 407 407
Lines 45557 45557
==========================================
- Hits 30538 30535 -3
- Misses 12796 12798 +2
- Partials 2223 2224 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sh#1845) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…sh#1845) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…sh#1845) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…sh#1845) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
This change addresses the issue where the ElasticQuota creation was failing during the initialization phase, which was leading to startup failures.
Ⅱ. Does this pull request fix one issue?
fix #1844.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test